+2001-10-23 Havoc Pennington <hp@redhat.com>
+
+ * gtk/gtktextview.c (changed_handler): Correctly keep the same
+ text on the top of the screen, considering that the changed region
+ may have overlapped the first paragraph. Should fix msw's "text
+ widget scrolled to wrong place on map" bug, and probably some
+ other scrolling cases as well.
+ (gtk_text_view_set_scroll_adjustments): start adjustments at 0.0,
+ instead of some random value
+
+ * gtk/gtktextview.c (gtk_text_view_class_init): actually override
+ grab_focus, so #59708 is really fixed
+
2001-10-24 Anders Carlsson <andersca@gnu.org>
* gtk/gtkentry.c: (append_action_signal): Use an image menu item here
* gtk/gtktextview.c (changed_handler): queue a resize here; will
temporarily slow down the widget a lot, until we figure out how to
- optimize to avoid full redraw everytime we queue a resize
+ optimize to avoid full redraw everytime we queue a resize.
2001-10-23 Havoc Pennington <hp@redhat.com>
+2001-10-23 Havoc Pennington <hp@redhat.com>
+
+ * gtk/gtktextview.c (changed_handler): Correctly keep the same
+ text on the top of the screen, considering that the changed region
+ may have overlapped the first paragraph. Should fix msw's "text
+ widget scrolled to wrong place on map" bug, and probably some
+ other scrolling cases as well.
+ (gtk_text_view_set_scroll_adjustments): start adjustments at 0.0,
+ instead of some random value
+
+ * gtk/gtktextview.c (gtk_text_view_class_init): actually override
+ grab_focus, so #59708 is really fixed
+
2001-10-24 Anders Carlsson <andersca@gnu.org>
* gtk/gtkentry.c: (append_action_signal): Use an image menu item here
* gtk/gtktextview.c (changed_handler): queue a resize here; will
temporarily slow down the widget a lot, until we figure out how to
- optimize to avoid full redraw everytime we queue a resize
+ optimize to avoid full redraw everytime we queue a resize.
2001-10-23 Havoc Pennington <hp@redhat.com>
+2001-10-23 Havoc Pennington <hp@redhat.com>
+
+ * gtk/gtktextview.c (changed_handler): Correctly keep the same
+ text on the top of the screen, considering that the changed region
+ may have overlapped the first paragraph. Should fix msw's "text
+ widget scrolled to wrong place on map" bug, and probably some
+ other scrolling cases as well.
+ (gtk_text_view_set_scroll_adjustments): start adjustments at 0.0,
+ instead of some random value
+
+ * gtk/gtktextview.c (gtk_text_view_class_init): actually override
+ grab_focus, so #59708 is really fixed
+
2001-10-24 Anders Carlsson <andersca@gnu.org>
* gtk/gtkentry.c: (append_action_signal): Use an image menu item here
* gtk/gtktextview.c (changed_handler): queue a resize here; will
temporarily slow down the widget a lot, until we figure out how to
- optimize to avoid full redraw everytime we queue a resize
+ optimize to avoid full redraw everytime we queue a resize.
2001-10-23 Havoc Pennington <hp@redhat.com>
+2001-10-23 Havoc Pennington <hp@redhat.com>
+
+ * gtk/gtktextview.c (changed_handler): Correctly keep the same
+ text on the top of the screen, considering that the changed region
+ may have overlapped the first paragraph. Should fix msw's "text
+ widget scrolled to wrong place on map" bug, and probably some
+ other scrolling cases as well.
+ (gtk_text_view_set_scroll_adjustments): start adjustments at 0.0,
+ instead of some random value
+
+ * gtk/gtktextview.c (gtk_text_view_class_init): actually override
+ grab_focus, so #59708 is really fixed
+
2001-10-24 Anders Carlsson <andersca@gnu.org>
* gtk/gtkentry.c: (append_action_signal): Use an image menu item here
* gtk/gtktextview.c (changed_handler): queue a resize here; will
temporarily slow down the widget a lot, until we figure out how to
- optimize to avoid full redraw everytime we queue a resize
+ optimize to avoid full redraw everytime we queue a resize.
2001-10-23 Havoc Pennington <hp@redhat.com>
+2001-10-23 Havoc Pennington <hp@redhat.com>
+
+ * gtk/gtktextview.c (changed_handler): Correctly keep the same
+ text on the top of the screen, considering that the changed region
+ may have overlapped the first paragraph. Should fix msw's "text
+ widget scrolled to wrong place on map" bug, and probably some
+ other scrolling cases as well.
+ (gtk_text_view_set_scroll_adjustments): start adjustments at 0.0,
+ instead of some random value
+
+ * gtk/gtktextview.c (gtk_text_view_class_init): actually override
+ grab_focus, so #59708 is really fixed
+
2001-10-24 Anders Carlsson <andersca@gnu.org>
* gtk/gtkentry.c: (append_action_signal): Use an image menu item here
* gtk/gtktextview.c (changed_handler): queue a resize here; will
temporarily slow down the widget a lot, until we figure out how to
- optimize to avoid full redraw everytime we queue a resize
+ optimize to avoid full redraw everytime we queue a resize.
2001-10-23 Havoc Pennington <hp@redhat.com>
+2001-10-23 Havoc Pennington <hp@redhat.com>
+
+ * gtk/gtktextview.c (changed_handler): Correctly keep the same
+ text on the top of the screen, considering that the changed region
+ may have overlapped the first paragraph. Should fix msw's "text
+ widget scrolled to wrong place on map" bug, and probably some
+ other scrolling cases as well.
+ (gtk_text_view_set_scroll_adjustments): start adjustments at 0.0,
+ instead of some random value
+
+ * gtk/gtktextview.c (gtk_text_view_class_init): actually override
+ grab_focus, so #59708 is really fixed
+
2001-10-24 Anders Carlsson <andersca@gnu.org>
* gtk/gtkentry.c: (append_action_signal): Use an image menu item here
* gtk/gtktextview.c (changed_handler): queue a resize here; will
temporarily slow down the widget a lot, until we figure out how to
- optimize to avoid full redraw everytime we queue a resize
+ optimize to avoid full redraw everytime we queue a resize.
2001-10-23 Havoc Pennington <hp@redhat.com>
+2001-10-23 Havoc Pennington <hp@redhat.com>
+
+ * gtk/gtktextview.c (changed_handler): Correctly keep the same
+ text on the top of the screen, considering that the changed region
+ may have overlapped the first paragraph. Should fix msw's "text
+ widget scrolled to wrong place on map" bug, and probably some
+ other scrolling cases as well.
+ (gtk_text_view_set_scroll_adjustments): start adjustments at 0.0,
+ instead of some random value
+
+ * gtk/gtktextview.c (gtk_text_view_class_init): actually override
+ grab_focus, so #59708 is really fixed
+
2001-10-24 Anders Carlsson <andersca@gnu.org>
* gtk/gtkentry.c: (append_action_signal): Use an image menu item here
* gtk/gtktextview.c (changed_handler): queue a resize here; will
temporarily slow down the widget a lot, until we figure out how to
- optimize to avoid full redraw everytime we queue a resize
+ optimize to avoid full redraw everytime we queue a resize.
2001-10-23 Havoc Pennington <hp@redhat.com>
widget_class->focus_out_event = gtk_text_view_focus_out_event;
widget_class->motion_notify_event = gtk_text_view_motion_event;
widget_class->expose_event = gtk_text_view_expose_event;
-
+ widget_class->grab_focus = gtk_text_view_grab_focus;
+
widget_class->drag_begin = gtk_text_view_drag_begin;
widget_class->drag_end = gtk_text_view_drag_end;
widget_class->drag_data_get = gtk_text_view_drag_data_get;
}
static void
-changed_handler (GtkTextLayout *layout,
- gint start_y,
- gint old_height,
- gint new_height,
- gpointer data)
+changed_handler (GtkTextLayout *layout,
+ gint start_y,
+ gint old_height,
+ gint new_height,
+ gpointer data)
{
GtkTextView *text_view;
GtkWidget *widget;
{
gboolean yoffset_changed = FALSE;
GSList *tmp_list;
+ int new_first_para_top;
+ int old_first_para_top;
- if (start_y + old_height <= text_view->yoffset - text_view->first_para_pixels)
+ /* If the bottom of the old area was above the top of the
+ * screen, we need to scroll to keep the current top of the
+ * screen in place. Remember that first_para_pixels is the
+ * position of the top of the screen in coordinates relative to
+ * the first paragraph onscreen.
+ *
+ * In short we are adding the height delta of the portion of the
+ * changed region above first_para_mark to text_view->yoffset.
+ */
+ gtk_text_buffer_get_iter_at_mark (get_buffer (text_view), &first,
+ text_view->first_para_mark);
+
+ gtk_text_layout_get_line_yrange (layout, &first, &new_first_para_top, NULL);
+
+ old_first_para_top = text_view->yoffset - text_view->first_para_pixels;
+
+ if (new_first_para_top != old_first_para_top)
{
- text_view->yoffset += new_height - old_height;
+ text_view->yoffset += new_first_para_top - old_first_para_top;
+
get_vadjustment (text_view)->value = text_view->yoffset;
yoffset_changed = TRUE;
}
text_view->hadjustment = hadj;
g_object_ref (G_OBJECT (text_view->hadjustment));
gtk_object_sink (GTK_OBJECT (text_view->hadjustment));
-
+
gtk_signal_connect (GTK_OBJECT (text_view->hadjustment), "value_changed",
(GtkSignalFunc) gtk_text_view_value_changed,
text_view);
text_view->vadjustment = vadj;
g_object_ref (G_OBJECT (text_view->vadjustment));
gtk_object_sink (GTK_OBJECT (text_view->vadjustment));
-
+
gtk_signal_connect (GTK_OBJECT (text_view->vadjustment), "value_changed",
(GtkSignalFunc) gtk_text_view_value_changed,
text_view);
gint dx = 0;
gint dy = 0;
+ /* Note that we oddly call this function with adj == NULL
+ * sometimes
+ */
+
text_view->onscreen_validated = FALSE;
- DV(g_print(">Scroll offset changed, onscreen_validated = FALSE ("G_STRLOC")\n"));
+ DV(g_print(">Scroll offset changed %s/%g, onscreen_validated = FALSE ("G_STRLOC")\n",
+ adj == text_view->hadjustment ? "hadj" : adj == text_view->vadjustment ? "vadj" : "none",
+ adj ? adj->value : 0.0));
if (adj == text_view->hadjustment)
{
projects / gtk4.git / commitdiff